On Saturday 10 July 2010 09:33:26 Denys Vlasenko wrote: > On Saturday 10 July 2010 06:03, Rob Landley wrote: > > On Friday 09 July 2010 18:08:52 Denys Vlasenko wrote: > > > On Thursday 08 July 2010 17:49, Rob Landley wrote: > > > > util-linux/acpid.c:147: error: 'SW_LID' undeclared (first use in this > > > > function) > > > > > > It builds for me with Aboriginal Linux 0.9.11 toolchain. > > > > Yup. That's using much more recent kernel headers than SuSE Linux > > Enterprise 10. (There's a build machine at work that has that.) > > > > > SW_LID is defined in > > > > > > fwl_uclibc_i686-0.9.11/include/linux/input.h > > > > Kernel header. Git annotate says: > > > > ed8f9e2f (Richard Purdie 2006-05-29 716)#define SW_LID > > > > It was added to the kernel headers in 2.6.17. > > > > It's possible that SuSE Linux Enterprise Server 10 is so old busybox can > > no longer be expected to build on it, but if so there should probably be > > some kind of policy statement. > > How about: "defconfig is not expected to build on every Linux distribution, > you might need to disable a few applets if your toolchain's kernel headers > are somewhat old"?
So putting an #ifdef into acpid making sure that this is #defined would be bad, but according to "git annotate util-linux/mount.c", this following was primarily applied by you almost exactly one year ago: #include <sys/mount.h> // Grab more as needed from util-linux's mount/mount_constants.h #ifndef MS_DIRSYNC # define MS_DIRSYNC (1 << 7) // Directory modifications are synchronous #endif #ifndef MS_UNION # define MS_UNION (1 << 8) #endif #ifndef MS_BIND # define MS_BIND (1 << 12) #endif #ifndef MS_MOVE # define MS_MOVE (1 << 13) #endif #ifndef MS_RECURSIVE # define MS_RECURSIVE (1 << 14) #endif #ifndef MS_SILENT # define MS_SILENT (1 << 15) #endif // The shared subtree stuff, which went in around 2.6.15 #ifndef MS_UNBINDABLE # define MS_UNBINDABLE (1 << 17) #endif #ifndef MS_PRIVATE # define MS_PRIVATE (1 << 18) #endif #ifndef MS_SLAVE # define MS_SLAVE (1 << 19) #endif #ifndef MS_SHARED # define MS_SHARED (1 << 20) #endif #ifndef MS_RELATIME # define MS_RELATIME (1 << 21) #endif Why are mount and acpid different? I can switch off acpid. I haven't used defconfig in years because it's become useless to me, I start with allyesconfig and apply a trimconfig file that switches off the stuff that's broken in some context or other. I'm just wondering what the reasoning for doing different things in different applets is. Rob -- GPLv3: as worthy a successor as The Phantom Meanace, as timely as Duke Nukem Forever, and as welcome as New Coke. _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
