On Friday 16 July 2010 15:14, Rob Landley wrote:
> It builds and boots (on i686, at least).  The shell prompt is a bit screwed 
> up, though:
> 
>   (i686:1) \w \$
> 
> CONFIG_FEATURE_EDITING_FANCY_PROMPT defaults to off,

Fixed, busybox-1.17.0-build_system.patch is updated.


> and for some reason that's  
> in the busybox library tuning menu instead of the shell menu.

Because not only shells can use line editing. It's a generic thing.


> I note that 
> CONFIG_FEATURE_EDITING_ASK_TERMINAL also defaults to off

Yes, because this is an ugly trick. Where "ugly" doesn't merely means
that its is not technically clean. It's worse than that:
it is quite easy to make answerback sequence to be fed
to a shell child.

> and using QEMU's  
> virtial serial console kind of needs that.  I thought that escape sequence 
> was 
> just a fallback that only got called if the tty ioctl query call thing didn't 
> return usable data?

No, this isn't fully implemented yet.... working.... aha, here is it:
please try

http://busybox.net/downloads/fixes-1.17.0/busybox-1.17.0-ask_terminal.patch

This patch will make e.g. hush to query window width using ESC [ 6 n
only if ioctl(TIOCGWINSZ) fails or returns bogus value of 0.

You need to not only confirm that it builds, but also try it
on the serial line and let me know whether it actually
does the trick. It may fail to work if ctl(TIOCGWINSZ) on the serial
line lies, that is, returns some invented nonzero width and height
and doesnt indicate the error.

> Hmmm... 
> 
> AAAAAHHHH!!!  #IFDEF SALAD!  My eyes!
> 
> Ahem: libbb/lineedit.c needs to be <strike>cleansed with fire</strike> 
> cleaned 
> up a bit.  With fire.

Sure it does.
-- 
vda
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to