On Thursday 29 July 2010 04:29, Jeremie Koenig wrote:
> ---
> coreutils/Config.src | 2 +-
> coreutils/stty.c | 23 +++++++++++++++--------
> 2 files changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/coreutils/Config.src b/coreutils/Config.src
> index 780b73f..35e51d6 100644
> --- a/coreutils/Config.src
> +++ b/coreutils/Config.src
> @@ -607,7 +607,7 @@ config FEATURE_STAT_FORMAT
> config STTY
> bool "stty"
> default y
> - depends on PLATFORM_LINUX
> + depends on PLATFORM_LINUX # works on Hurd, still broken on FreeBSD
> help
> stty is used to change and print terminal line settings.
>
> diff --git a/coreutils/stty.c b/coreutils/stty.c
> index c40d718..98d5e7b 100644
> --- a/coreutils/stty.c
> +++ b/coreutils/stty.c
> @@ -1093,27 +1093,32 @@ static void set_mode(const struct mode_info *info,
> int reversed,
> mode->c_cc[VTIME] = 0;
> }
> }
> - else if (IXANY && info == &mode_info[IDX_decctlq]) {
> +#if IXANY
> + else if (info == &mode_info[IDX_decctlq]) {
Rob doesn't like #if forests. I think he is right.
Please add
#ifndef IXANY
# define IXANY 0
#endif
and similar constructs somewhere at the top...
eh... there is such thing already: see
/* Save set_mode from #ifdef forest plague */ comment.
Just more that code block up, and change all #ifdef IXANY to #if IXANY below it.
--
vda
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox
