On 13.08.2010 06:23, Denys Vlasenko wrote:
So, is it safe to assume that this needs to be cleaned up since it is not used anywhere else?head and tail also use it: # grep -r INCLUDE_SUS . ./TEST_config_rh9:CONFIG_INCLUDE_SUSv2=y ./coreutils/tty.c: IF_INCLUDE_SUSv2(int silent;) /* Note: No longer relevant in SUSv3. */ ./coreutils/tty.c: IF_INCLUDE_SUSv2(silent = getopt32(argv, "s");) ./coreutils/tty.c: IF_INCLUDE_SUSv2(argv += optind;) ./coreutils/tty.c: IF_NOT_INCLUDE_SUSv2(argv += 1;) ./coreutils/tty.c: IF_INCLUDE_SUSv2(if (!silent) puts(s);) ./coreutils/tty.c: IF_NOT_INCLUDE_SUSv2(puts(s);) ./coreutils/fold.c: if (ENABLE_INCLUDE_SUSv2) { ./coreutils/head.c:#if ENABLE_INCLUDE_SUSv2 || ENABLE_FEATURE_FANCY_HEAD ./coreutils/head.c:#if ENABLE_INCLUDE_SUSv2 || ENABLE_FEATURE_FANCY_HEAD ./coreutils/tail.c:#if ENABLE_INCLUDE_SUSv2 || ENABLE_FEATURE_FANCY_TAIL ./Config.in:config INCLUDE_SUSv2 ./TEST_config_nommu:CONFIG_INCLUDE_SUSv2=y ./include/usage.src.h: IF_INCLUDE_SUSv2( "\n" \ ./testsuite/tail/tail-works:# FEATURE: CONFIG_INCLUDE_SUSv2 ./TEST_config_noprintf:CONFIG_INCLUDE_SUSv2=y
No, head and tail use ENABLE_INCLUDE_SUSv2, but not IF_INCLUDE_SUSv2. So, what can be done about that? Is changing IF_INCLUDE_SUSv2 codeblocks with #if ENABLE_INCLUDE_SUSv2 sufficient? _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
