Hallo Denys! > This is all good, but will it solve this? No! > That's for var_bash5.tests which ash currently fails. I missed that topic. Sorry, I'm currently busy and additionally I have gone ill again. So I have not got the full discussion. But it solves some trouble I just had with busybox 1.17.1 using the substitution feature.
> This can't be fixed by merely tweaking parse_sub_pattern(), > because parse_sub_pattern() gets called _after_ the expansion. True. > Therefore I think it's pointless to play with parse_sub_pattern() It allows the substitutions to be used to change a slash, star, question mark or range specification. Which would otherwise not be possible. > before the more fundamental problem is fixed: the / shall be detected > _before_ the expansion step. That fix will be more intrusive and > will likely affect parse_sub_pattern() a lot. It is more intrusive because it needs to be done during parsing and the lexer is a brain damaged thing ... it is based on the output of an very old flex. But I don't acknowledge that this change has to affect parse_sub_pattern a lot. Depending on how you add this into the parser you either needn't to change parse_sub_pattern a lot or you can just drop it completely as it's no longer needed. As long as we don't have that parser fix, I would like to have at least this modification of parse_sub_expression to be included (despite it produces any errors or other bugs). -- Harald _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
