On Wed, Oct 20, 2010 at 2:18 PM, Sam Liddicott <[email protected]> wrote:
> So... if I fix the indenting, is the patch likely to be accepted?

I proposed deleting -c altogether, and using -x 61:hexstring
to specify client id.

To make it easier for users to see how to use -x,
help text can have examples added to it:

# ./busybox udhcpc --help
BusyBox v1.18.0.git (2010-10-20 13:29:07 CEST) multi-call binary.

Usage: udhcpc [-fbnqvoCR] [-i IFACE] [-r IP] [-s PROG] [-p PIDFILE]
        [-H HOSTNAME] [-V VENDOR] [-x OPT:VAL]... [-O OPT]... [-P N]

        -i,--interface IFACE    Interface to use (default eth0)
        -p,--pidfile FILE       Create pidfile
        -r,--request IP         IP address to request
        -s,--script PROG        Run PROG at DHCP events (default
/usr/share/udhcpc/default.script)
        -t,--retries N          Send up to N discover packets
        -T,--timeout N          Pause between packets (default 3 seconds)
        -A,--tryagain N         Wait N seconds after failure (default 20)
        -f,--foreground         Run in foreground
        -b,--background         Background if lease is not obtained
        -S,--syslog             Log to syslog too
        -n,--now                Exit if lease is not obtained
        -q,--quit               Exit after obtaining lease
        -R,--release            Release IP on exit
        -P,--client-port N      Use port N (default 68)
        -a,--arping             Use arping to validate offered address
        -O,--request-option OPT Request option OPT from server (cumulative)
        -o,--no-default-options Don't request any options (unless -O is given)
        -x OPT:VAL              Include option OPT in sent packets (cumulative)
                                Examples: -x hostname:bbox -x 61:0100ffee11cc55
        -F,--fqdn NAME          Ask server to update DNS mapping for NAME
        -H,-h,--hostname NAME   Send NAME as client hostname (default none)
        -V,--vendorclass VENDOR Vendor identifier (default 'udhcp VERSION')
        -C,--clientid-none      Don't send MAC as client identifier
        -v                      Verbose

Does this look ok? Is help text sufficiently clear?

-- 
vda
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to