On Wednesday 26 January 2011 15:24:17 Gilles Espinasse wrote:
> Selon Tito <[email protected]>:
>
> > Hi,
> > in id.c maybe I've found a minor bug.
> >
> > } else if (n < 0) { /* error in get_groups() */
> > - if (!ENABLE_DESKTOP)
> > + if (ENABLE_DESKTOP)
> > bb_error_msg_and_die("can't get groups");
> > else
> > return EXIT_FAILURE;
> > }
> >
> >
> > ciao,
> > Tito
>
>
> Another issue.
>
> Should really 'return EXIT_FAILURE' depend of ENABLE_DESKTOP?
>
>
> Gilles
>
My idea was ENABLE_DESKTOP = bloat so verbose error message
!ENABLE_DESKTOP= minimal so only return error to shell
Maybe I'm overlooking something obvious?
Ciao,
Tito
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox
