On Sun, Feb 13, 2011 at 2:37 AM, Denys Vlasenko <[email protected]> wrote: > On Saturday 12 February 2011 11:22, [email protected] wrote: >> On Sat, Feb 12, 2011 at 3:26 AM, [email protected] <[email protected]> >> wrote: >> > On Sat, Feb 12, 2011 at 3:11 AM, [email protected] <[email protected]> >> > wrote: >> >> Hi, >> >> I'm a beginner, this is my first "patch", surely is buggy. I think >> >> that it can't be so easy, but I haven't observed any problems so far. >> >> I will reindent if the patch is ok. >> >> Please review. >> >> >> >> Regards, >> >> Pere. >> >> >> >> PS: Currently busybox's wget doesn't handle auto-renaming filenames >> >> (adding a number, to filename.N) if file exits. That's another >> >> -related- patch. >> >> >> > >> > Ehm, first problem, with -O option only last file is saved to disk. >> > I'm sorry. I will look at it tomorrow. >> > >> > Pere. >> >> Hi again, >> attached another version of the patch. > > - > + while (optind < argc) { > target.user = NULL; > > while {} block needs to be indented. > Do you expect that someone else will do reindentation for you? >
I did not indent for an easier review. > > > The existing code leaks memory in many places. It wasn't a problem > for single-URL download, but for multi-URL is it. > I will look at it. > -- > vda > Thanks for review, Pere. _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
