On Fri, Apr 15, 2011 at 07:17:22PM +0100, Chris Rees wrote: > Hi, > > Is it vital that 'sed --' is used in scripts/gen-build-files.sh? > > It uses the variable $srcdir, which is set in the Makefile to an > absolute path; although of course it would normally be sensible to use > -- when using a variable. > > Unfortunately this causes non-GNU sed to break on scripts/gen-build-files.sh. > > I've got around it so far by using GNU sed, but it'd be great to > remove that dependency from my point of view. > > Would the patch at [1] be acceptable?
I second this. Even busybox itself only recently supports this usage, and it's not even clear to me from reading the standard whether it's conformant for an implementation to support this usage. If you want to use --, I think it's required to use -e or -f, not an implicit -e. But I would just remove the -- and be done with it. Rich _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
