On Wednesday 29 June 2011 17:41, Federico Vaga wrote: > No error is displayed when you try to unload a nonexistent module; only if > debug mode is active a message is showed. It can be a problem because on > missed typeing error busybox do not return error and it might be thought that > the real module is removed, but it not and it might be a problem. > > Signed-off-by: Federico Vaga <[email protected]> > --- > modutils/modprobe-small.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/modutils/modprobe-small.c b/modutils/modprobe-small.c > index 57b83c0..e7c241a 100644 > --- a/modutils/modprobe-small.c > +++ b/modutils/modprobe-small.c > @@ -532,7 +532,7 @@ static void process_module(char *name, const char > *cmdline_options) > > dbg1_error_msg("already_loaded:%d is_rmmod:%d", already_loaded(name), > is_rmmod); > if (already_loaded(name) != is_rmmod) { > - dbg1_error_msg("nothing to do for '%s'", name); > + bb_error_msg("nothing to do for '%s'", name); > return; > }
This broke "modprobe ALREADY_LOADED_MODULE" - now it talks. It should not. -- vda _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
