On 07/23/2011 12:57 PM, Douglas Mencken wrote:
> Well, this workaround does work:
>
> sed -i '/Include our own copy of struct
> sysinfo/{NNNNNNNNNNNNNNNNNN;d}' ./include/libbb.h
>
> But of course, it would be better to surround sysinfo struct def with
> #ifndef and/or, if it is so important to keep libbb's one definition,
> to #undef it.
I think it's kind of disgusting from a design standpoint to block copy
structures out of header files. Back when Erik was in charge I spent
rather a long time cleaning things up so we could just #include
<linux/loop.h> in losetup and friends and use what it defines.
Block-copying crap out of headers in the name of portability NEVER
helps. I don't know why we keep needing to re-learn this lesson:
http://www.mail-archive.com/[email protected]/msg10937.html
It's a bad idea at a conceptual level, and I don't know why it's doing
it. Spending mountains of code working around other people's problems
is how you get the gnu tools. If busybox fills up with that, we'll need
a busybox for busybox.
Rob
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox
