On Tue, 04 Sep 2012 08:45:09 -0500, Sedat Dilek <[email protected]>
wrote:

On Tue, Sep 4, 2012 at 3:36 PM, Joshua Kahlenberg <[email protected]> wrote:
On Tue, 04 Sep 2012 03:13:38 -0500, Denys Vlasenko
<[email protected]> wrote:

On Sun, Sep 2, 2012 at 7:42 PM, Joshua Kahlenberg <[email protected]>
wrote:

Sorry, previous patch was wrapped


And this version is mangled too:

Content-Type: text/plain; charset="us-ascii"; Format="flowed";
DelSp="yes"


Flowed format causes all kinds of PITA.

Please resend as attachment.

 //usage:       "sysctl [-n] [-e] -A\n"
+//usage:       "sysctl [-n] [-e] -q\n"


No, -q is not used like this. Add "[-q]"
to those lines where it makes sense.

+               if (!(option_mask32 & FLAG_QUIET))
                puts(value);


puts() should get one additional tab of indentation.


Here is the patch as an attachment with the above changes.


Can you use sth. like 'git send-email' to send patches?
So people can easier review by commenting (the content of) your (patch
in the) email?

- Sedat -

--
jbkberg (AT) gmail.com
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Okay. I'll try that next time I submit a patch.

--
jbkberg (AT) gmail.com
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to