On Fri, May 31, 2013 at 11:05:56PM -0400, Mike Frysinger wrote: > > uses sscanf like this on lines 239 and 245. I'm certainly open to > > updating my patch to use xstrtou if that's preferable, it won't match > > the existing code but I suppose another commit at some point could > > change that. > > yes, sometimes bad code gets merged and we should fix it rather than continue > the practice :)
It seemed cleaner to convert the existing sscanf calls to xstrtou before adding new code using it, so I went ahead and submitted a patch doing so. I'll follow up with my previous addition reworked with xstrtou. > see libbb/xatonum_template.c Ah, ok; I was looking at xatonum.c and it wasn't immediately obvious what was going on, I see the preprocessor magic now. > the right answer is whatever is smaller. Heh, I guess this is busybox after all :). I'll rework that one and resubmit it. _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
