On Thu, 9 Jan 2014, Denys Vlasenko wrote: > On Wed, Jan 8, 2014 at 5:50 PM, Cristian Ionescu-Idbohrn > <[email protected]> wrote: > > The code suggests this patch: > > > > From e68af87e1e38911bb3dd653ad36701f81dbbdc3f Mon Sep 17 00:00:00 2001 > > From: Cristian Ionescu-Idbohrn <[email protected]> > > Date: Wed, 8 Jan 2014 17:40:25 +0100 > > Subject: [PATCH] Make usage and code agree with each other. > > > > Signed-off-by: Cristian Ionescu-Idbohrn <[email protected]> > > --- > > coreutils/chown.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/coreutils/chown.c b/coreutils/chown.c > > index 1a91276..c87433c 100644 > > --- a/coreutils/chown.c > > +++ b/coreutils/chown.c > > @@ -40,7 +40,7 @@ > > /* This is a NOEXEC applet. Be very careful! */ > > > > > > -#define OPT_STR ("Rh" IF_DESKTOP("vcfLHP")) > > +#define OPT_STR ("RhLHP" IF_DESKTOP("vcf")) > > #define BIT_RECURSE 1 > > #define OPT_RECURSE (opt & 1) > > #define OPT_NODEREF (opt & 2) > > -- > > 1.8.5.2 > > > > is the intended behaviour, unless I'm missing something. > > This doesn't look right. > > #define OPT_VERBOSE (IF_DESKTOP(opt & 0x04) IF_NOT_DESKTOP(0)) > > > suggests that "v" should be the third option, your patch makes it sixth.
Yes. I did miss something after all :( Nevertheless, are the POSIX options LHP intended to be default (as usage suggests) or DESKTOP dependent? Cheers, -- Cristian _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
