On 2014-03-19 01:28, [email protected] wrote:
> Running 'make distclean' does not remove various generated files in the "docs"
> directory. This has frustrated me when trying to make patches against BusyBox,
> as I cannot clean the folders properly without manually deleting files. The
> attached patch adds these generated docs to the "make distclean" list to be
> removed, thus truly cleaning to a pristine distribution state.
> 
> Signed-off-by: Jody Bruchon <[email protected]>

Git can help you ignore such files (thanks to docs/.gitignore) and make
patches (either with just `git diff` or by committing changes in a
branch and generating mail messages with `git format-patch`).

> diff -Naurw a/Makefile b/Makefile
> --- a/Makefile        2014-01-19 21:39:28.000000000 -0500
> +++ b/Makefile        2014-03-19 01:02:02.529223008 -0400
> @@ -973,6 +973,11 @@
>                 include/applets.h \
>                 include/usage.h \
>                 applets/usage \
> +               docs/BusyBox.html
> +               docs/BusyBox.txt
> +               docs/busybox.1
> +               docs/busybox.net/BusyBox.html
> +               docs/busybox.pod
>                 .kernelrelease Module.symvers tags TAGS cscope* \
>                 busybox_old

You need to escape the newline characters in the added lines with "\".
With that fix, the patch looks fine to me for what that's worth.

-- 
Patrick "P. J." McDermott
  http://www.pehjota.net/
Lead Developer, ProteanOS
  http://www.proteanos.com/
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to