Harald Becker wrote:
Your program will fail on lines starting with the word server
(eg. serverxyz), that is it does not check for clear word
boundary and gives wrong results in that case.
The program will not fail for serverxyz, it will add a server "xyz".
This may be a bug or a feature :-)
while (cbuf[i] > 35) i++;
Unwise to do this in a not poor ASCII environment, as most
systems are nowadays. This way you allow unprintable and any
kind of illegal characters in time server addresses.
What is special about 35? Why is ' fine while " is not?
Of course the configuration comes from someone who already has root
access, so whatever happens here to an invalid input can't be worse than
"rm -rf /".
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
