Hello, 2014-12-11 16:40 GMT+01:00 Bartosz Gołaszewski <[email protected]>: > 2014-12-10 13:48 GMT+01:00 walter harms <[email protected]>: >> instead of checking two possible path let the user/system decide. >> This can be done automagicly by checking the LINUX_VERSION like: >> >> #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0) /* used in loop.c */ >> >> or you can let the user decide by providing an entry in Config.src > > I think this is an overkill for the few bytes saved.
Well, I think it's better with conditional compiling... This way would make the code easier to understand. Indeed, it doesn't make sense to try to open a device in a path when you known it wont be there. Moreover, with the current code it will warn if you don't have the correct kernel... That, IMHO, isn't convenient. Cheers, Xabier Oneca_,,_ _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
