Hi Paul, On Thu, Dec 25, 2014 at 11:24 PM, Isaac Dunham <[email protected]> wrote: > On Thu, Dec 25, 2014 at 08:43:21PM +0100, Denys Vlasenko wrote: >> >> Copyright notice there is already a mess (both GPL and BSD ... that's >> >> wrong). >> >> >> >> With your patch, it adds another BSD clause. Also, ntpd_simple.c >> >> also needs fixing, right? >> >> >> >> Please submit a patch which replaces existing notice with a consistent >> >> one. >> > >> > I'm not licensing expert but IMO it's impossible to merge all licenses into >> > one statement as you wish. If you use existing code, you cannot change >> > license unless you are author. If licenses differ for parts of code, all of >> > them should be mentioned. >> > >> > I dig on the Internet about possibility to "relicense" BSD code under GPL >> > and it's not possible. However it's possible to license changes to BSD code >> > under GPL. So in my opinion the best solution is to mention all of the >> > license notices (from both OpenNTPd and NTPd) and license all busybox >> > changes under GPL. What do you think about attached patch? >> >> Basically it says that the original source is under BSD license >> and all changes are under GPL. This is possibly legal, but surely is a mess >> (whoever would want to disentangle it will need to discover the original). >> >> How about just respecting original authors' BSD license? >> I'm not a license zealot. >> You and me, as authors, still can re-license all our changes. > > I prefer seeing the original license preserved in general, but if you > take that course, I'd assume you will need to contact at least the > first three of the other Busybox contributors who modified ntpd: > Miroslav Lichvar > Jean-Christophe Dubois > Paul Marks
Paul, do you agree or object to your contribution to ntpd.c, namely: commit b7841cf7b919b16d1bd4619154bf7cb4c22b4ccd Author: Paul Marks <[email protected]> Date: Mon Jan 14 02:39:10 2013 +0100 ntpd: fix incorrect m_status field in outgoing packets. Closes 5120 ... /* Build a reply packet */ memset(&msg, 0, sizeof(msg)); - msg.m_status = G.stratum < MAXSTRAT ? G.ntp_status : LI_ALARM; + msg.m_status = G.stratum < MAXSTRAT ? (G.ntp_status & LI_MASK) : LI_ALARM; to be under BSD style license? -- vda _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
