Fix applied. Sorry!
On Thu, Mar 19, 2015 at 3:51 PM, Ken Sharp <[email protected]> wrote: > Hi Vladislav, > > It appears that my original patch was (legitimately) refactored and the > inversion in logic was introduced. Good catch! > > Regards, > Ken Sharp > > > > From: "Vladislav Grishenko" <[email protected]> > To: "'Denys Vlasenko'" <[email protected]>, "'Ben Shelton'" > <[email protected]>, > Cc: "'busybox'" <[email protected]>, "'Ken Sharp'" > <[email protected]> > Date: 03/19/2015 06:30 AM > Subject: RE: [PATCH] zcip: fix link-local IP conflict detection > > > > Hi Denys, > > Applied commit "a4d564ad zcip: fix link-local IP conflict detection" has > introduced wrong > comparison of source IP with our/choosen IP. This again leads to a new IP > being repacked > on every incoming ARP packet. > Please refer patch against current git attached. > > Best Regards, Vladislav Grishenko > >> -----Original Message----- >> From: [email protected] [mailto:busybox- >> [email protected]] On Behalf Of Denys Vlasenko >> Sent: Sunday, July 20, 2014 6:03 PM >> To: Ben Shelton >> Cc: busybox; Ken Sharp >> Subject: Re: [PATCH] zcip: fix link-local IP conflict detection >> >> On Thu, Jul 17, 2014 at 6:34 PM, Ben Shelton <[email protected]> wrote: >> > From: Ken Sharp <[email protected]> >> > >> > During link-local IP resolution, if a regular ARP request is received >> > during the ARP probe period, it will incorrectly cause a target IP >> > conflict. This then leads to a new IP being picked unnecessarily. >> > >> > Per RFC 3927, section 2.2.1, we should flag a target IP conflict only >> > if the source IP is null, the target IP matches our IP, and the source >> > hw addr does not match our hw addr. >> > >> > Signed-off-by: Ken Sharp <[email protected]> >> > Signed-off-by: Ben Shelton <[email protected]> >> > --- >> > >> > Note that we reproduced the issue and tested the fix on an ARM >> > A9-based board as follows: >> > >> > - Connect two machines via a crossover cable or on a network with no >> DHCP >> > server available. >> > - Continuously ping the machine running busybox from the other >> > - Reboot the busybox machine (the one being pinged) >> > - When the busybox machine comes back up it will have a different IP >> > address because of the incorrect target IP conflict >> > >> >> >> Applied, thanks! >> _______________________________________________ >> busybox mailing list >> [email protected] >> http://lists.busybox.net/mailman/listinfo/busybox > [attachment > "0001-zcip-fix-wrong-comparison-of-source-IP-with-our-IP.patch" deleted by > Ken Sharp/AUS/NIC] > _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
