> -----Original Message----- > From: Bernhard Reutner-Fischer [mailto:[email protected]] > Sent: den 14 juni 2016 15:58 > To: Timo Teras; Jonas Danielsson > Cc: [email protected] > Subject: Re: [PATCH] networking: ping: Avoid zero checksum in simple ping > > On June 14, 2016 1:49:43 PM GMT+02:00, Timo Teras <[email protected]> > wrote: > >On Tue, 14 Jun 2016 10:41:46 +0000 > >Jonas Danielsson <[email protected]> wrote: > > >Technically, if two users ping same host at same time, the ping replies > >can be confused for each other. Ping tool should use random() or > >getpid() or similar way to select id, and filter the responses to match > >id sent. > > Yes, but does the non-fancy ping filter on the id? I don't have the sources at > hand.. >
What are you asking here? Currently the non-fancy ping sets identification to 0. Which is ok by RFC. The host that replies looks at that and sends an Echo reply with identification of 0. The problem can arise if we have two different ping applications pinging the same host, then we could get the replies confused, I guess. Right now the non-fancy ping has no protection against that. The fancy one uses getpid() if we think using getpid() is too fancy for the non-fancy ping we could switch to a constant. But if we are adding identification to non-fancy ping maybe we could add protection against mismatch as well? > thanks, Thank you _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
