On 4 Jul 2016 at 16:42, Denys Vlasenko wrote: From: Denys Vlasenko <[email protected]> Date sent: Mon, 4 Jul 2016 16:42:15 +0200 Subject: Re: Question on bb_info_msg, printf, and bb_error_msg? To: "Michael D. Setzer II" <[email protected]> Copies to: busybox <[email protected]>
> On Sun, Jun 26, 2016 at 5:06 AM, Michael D. Setzer II > <[email protected]> wrote: > > Posted an earlier message about changes in 1.25.0. > > At the time, I didn't find mention of these in the changes listed, but > > didn't > > know that it was the change from using bb_info_msg to bb_error_msg that > > was change output to go to stderr instead of stdout. Noticed that other > > changes have bb_info_msg going to printf? So, what was the problem with > > bb_info_msg that it needed to be changed? > > bb_info_msg() had only a handful of users, so it looked inconsistent: > "if most applets can live without it, maybe all of them could?" > > > And why where some changes > > to printf and other to bb_error_msg?? Also, noted a major changes in the > > text, where before they started with a capital letter, but now are all lower > > case? > > Logging messages almost everywhere were emitted via bb_error_msg. > Thus, bb_info_msg's which were emitting log messages were converted > to bb_error_msg. Since bb_error_msg prefixes applet name, > capitalization was changed. > > bb_info_msg's which emitted other messages were converted to printfs, > IOW: no change in functionality (still goes to stdout, still not prefixed). I'll have to check on that? May have been that I saw that output on screen, but piping it thru the grep didn't find output. May have been that it is just the case of the text that was causing the failure in the code. Currently 7 timezones away for build system, and it is currently offline. Hopefully, will have a co-working check on it shortly. Still, changing the case of messages will require either adding the -i to grep commands or manually changing text. Know that I have seen some out lines have text with same words in different case, so have case insensitive seach could cause other issues as well. Where exactly is the bb_error_msg defined? I though bb_info_msg was for output to stdout, and bb_error_msg was for stderr?? Thanks. +----------------------------------------------------------+ Michael D. Setzer II - Computer Science Instructor Guam Community College Computer Center mailto:[email protected] mailto:[email protected] Guam - Where America's Day Begins G4L Disk Imaging Project maintainer http://sourceforge.net/projects/g4l/ +----------------------------------------------------------+ http://setiathome.berkeley.edu (Original) Number of Seti Units Returned: 19,471 Processing time: 32 years, 290 days, 12 hours, 58 minutes (Total Hours: 287,489) BOINC@HOME CREDITS ABC 16613838.513356 | EINSTEIN 103574037.45569545684502.862785 ROSETTA 45684502.862785 | SETI 85964346.495298 _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
