>>>>> "Francis" == Francis Rounds <[email protected]> writes:

 > When using svlogd's processor functionality to run arbitrary commands
 > on log rotation, the line in the config is executed verbatim, i.e. the
 > exclamation mark is included.

 > For example, if the config file contains:

 >     s100
 >     !cat

 > then when it's time to rotate the log files after each 100 bytes, sh -c
 > "!cat" will be run, instead of sh -c "cat" as intended. The result is
 > svlogd logging

 >     /bin/bash: !cat: command not found
 >     svlogd: warning: processor failed, restart: /tmp/svlogd/

 > over and over again as it keeps attempting to execute the processor and
 > failing (unless you happen to have a "!cat" binary around :)).

 > Skipping the exclamation mark when performing the wstrdup() fixes the
 > issue.

 > Signed-off-by: Francis Rounds <[email protected]>

Argh, indeed :/

Acked-by: Peter Korsgaard <[email protected]>

-- 
Bye, Peter Korsgaard
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to