On Mon, Feb 6, 2017 at 4:38 AM, Kang-Che Sung <[email protected]> wrote: > On Mon, Feb 6, 2017 at 2:04 AM, Denys Vlasenko <[email protected]> > wrote: >> Applied a simpler version of it. Thanks >> >> On Wed, Feb 1, 2017 at 10:22 AM, Kang-Che Sung <[email protected]> wrote: >>> - The modprobe-small implementation of rmmod no longer chdir's to >>> "/lib/modules/`uname -r`" as it was not necessary for rmmod's >>> operation. (And it no longer need to die if such modules directory >>> doesn't exist.) >>> - Configs DEFAULT_MODULES_DIR and DEFAULT_DEPMOD_FILE no longer depend >>> on MODPROBE_SMALL as the latter may not enable depmod or modprobe >>> that requires these configs. >>> - Clarify DEFAULT_DEPMOD_FILE's description regarding the ".bb" name >>> suffix. >>> > > Thank you, but I hope you understand why I propose the not-so-simple route in > the patch. Especially regarding the use of is_depmod_or_modprobe macro.
Not really. If you would explain it, it might increase chances of it being accepted. Since I had to guess, I guessed "it probably saves a few bytes of code at the cost of many more #ifdefs. _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
