On 8 March 2017 21:11:15 CET, Hans Ulli Kroll <[email protected]> wrote:
>Hi Bernd,
>
>On Wed, 8 Mar 2017, tiggersWelt.net (Support) wrote:
>
>> Hey there,
>> 
>> this is my first post on the list and my first set of patches I wrote
>> for busybox, so please forgive me if I'm missing something.
>>
>
>Please read:
>Documentation/process/submitting-patches.rst 
>in the linux source tree.
>
>I think busybox is mostly following this. And if you are using git for 
>create and send patches this is fine, the diff section is out of date.

Right.
Furthermore in options use xmalloc and cap the length. Somehow olen computation 
feels like occurring way too often; look at bloat-o-meter output (which you 
should include in every patch) and try to tweak/rephrase what you want.
Apart from that it looks like a good thing, please resend?

Cheers,
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to