Hi Assaf, On Thu, Jun 29, 2017 at 06:08:10PM -0400, Assaf Gordon wrote: > Hello Patrick and all, > > > On Jun 29, 2017, at 13:34, Patrick Steinhardt <[email protected]> wrote: > > > > I've recently been digging into setpriv from util-linux and > > implemented ambient capabilities. > [...] > > I first want to gauge interest in increasing the scope of setpriv > > with these patches. If you as a project are interested, I'll > > implement additional missing bits such as changing users and > > groups, making it complete for at least my own use cases. > > This all looks good and useful to me (but i'm not a busybox developer).
Thanks for your feedback! > One small suggestion: perhaps consider making each sub-part optional > at compilation time? so that if someone doesn't need "--dump" or doesn't > need "--cap" or "--inh-caps", they can build a smaller binary without them ? This seems sensible and should be easy to achieve, I guess, as the parts aren't too tangled up with each other. I'll await additional feedback and do this in v2. > Also, > Thanks for spotting and fixing the getopt bug in my previous code. > > regards, > - assaf Regards Patrick
signature.asc
Description: PGP signature
_______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
