Hi.

>From a quick scan of the patch, the sscanf seems wrong?  You have %ud, and I 
>assume you meant either %u or %d?

int FAST_FUNC volume_id_probe_reiserfs(struct volume_id *id /*,uint64_t off*/)
 {
+    len = sscanf(rs->s_v1.s_magic, "ReIsEr%udFs", &ver);
+    if (!len) {
+        if (strcmp(rs->s_v1.s_magic, REISERFS_3_5_SUPER_MAGIC_STRING) != 0)
+            goto x_mgc_str;

Regards,

Mark



________________________________
From: busybox <busybox-boun...@busybox.net> on behalf of haroon maqsood 
<maqsood3...@live.com>
Sent: October 05, 2018 02:11
To: busybox@busybox.net
Subject: [PATCH][volume_id][reiserfs structures and etc]

Hi,
PFA a patch to try and streamline the reiserfs structures in use, from 
volume_id and mkfs_reiser.
i also made some changes to the volume_id probe function for reiserfs, please 
let me know if you would prefer it in 2 patches.
the structures are used from reiserfsprogs 3.6.27, was there a reason the 
structures were changed ?, please let me know if am missing something
Thanks
Haroon
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to