Having a quick look, I'd say it introduces an unexpected behaviour at best.
I can in no way personally see any benefits with the patch, since most sane
users run services supervised and actually want a pidfile. The rare exception
is if you don't know about "runit" or have really small RAM.
If a change is only good for a special purpose; then it would shouldn't be
upstreamed imho.
//M
Sent from my BlackBerry — the most secure mobile device
Original Message
From: [email protected]
Sent: 27 August 2019 15:51
To: [email protected]
Subject: Re: [PATCH] config: PID_FILE_PATH required for
FEATURE_CROND_SPECIAL_TIMES
On 17/07/2019 16:53, James Byrne wrote:
> When crond is built with FEATURE_CROND_SPECIAL_TIMES enabled, it creates
> a file called 'crond.reboot' at CONFIG_PID_FILE_PATH, but if
> FEATURE_PIDFILE is disabled, this will be an empty string and the file
> will be created in the root directory, which is undesirable.
>
> This commit makes PID_FILE_PATH depend on FEATURE_CROND_SPECIAL_TIMES as
> well as FEATURE_PIDFILE so that you get sensible behaviour in crond when
> FEATURE_PIDFILE is switched off.
>
> Signed-off-by: James Byrne <[email protected]>
Hi,
I posted this patch a while back but haven't seen any replies. Are there
any issues with this change?
Thanks,
James
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox
