On 9/25/19 2:03 PM, Michal Kazior wrote:
From: Michal Kazior <[email protected]>

The following caused udhcpc to segfault:
   busybox udhcpc -i lo -s /dev/null -x 0x3d:

Signed-off-by: Michal Kazior <[email protected]>
---
  networking/udhcp/common.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/networking/udhcp/common.c b/networking/udhcp/common.c
index 4a452cdb9..9ec752dfc 100644
--- a/networking/udhcp/common.c
+++ b/networking/udhcp/common.c
@@ -539,7 +539,7 @@ int FAST_FUNC udhcp_str2optset(const char *const_str, void 
*arg,
if (optflag->flags == OPTION_BIN) {
                        val = strtok(NULL, ""); /* do not split "'q w e'" */
-                       trim(val);
+                       if (val) trim(val);
                } else
                        val = strtok(NULL, ", \t");
                if (!val)


Hi,

wouldn't it make more sense to put this in libbb/trim.c so it is fixed 
definitely?

ciao,
Tito
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to