My recommendation is not to upgrade unless there are good reasons to do so (since busybox holds no guarantees and may and certainly does break functionality between versions (which itself is pretty much an inherent issue due to its nature and would require some QA engineers paid and assigned to the project, albeit and unfortunately those end up being hired on the other end of the ecosystem)).
Besides the mail is not related to the git version so I would suggest filing a regression bug in the bugtracker https://bugs.busybox.net/ Denys can be quite friendly if you file a reproductive behavior and are willing to share the promt.sh and other details of your setup like compiler version and hardware architecture. //M Sent from my BlackBerry — the most secure mobile device Original Message From: [email protected] Sent: 19 October 2019 16:34 To: [email protected] Subject: Re: [PATCH] ash: only catch unexpected exceptions in PS1 expansion On Wed, Jul 31, 2019 at 01:45:23PM +0200, Denys Vlasenko wrote: > Applied, thanks! > > On Mon, Jul 29, 2019 at 11:00 AM Ron Yorston <[email protected]> wrote: > > > > Commit d1a2fa2a4 (ash: catch error in arithmetic expansion in PS1) > > catches all exceptions raised by expandarg(). Some exceptions, such as > > the EXEXIT raised when command expansion is used, are expected: > > > > export PS1='$(echo "$ ")' > > > > These should be processed normally or the shell hangs at the prompt. Maybe i am a "victim" of this patch: With busybox v1.31.0 on OpenWrt my login "hangs" during the prompt. Attached is a script, which is sourced during profile.d You can reproduce the issue by sourcing this script on a system, e.g. user@box # . /tmp/prompt.sh After that, i cannot see what i type anymore. What works is e.g. uptime | logger -s Also reseting the terminal with 'reset' does not help. With older busybox-versions, e.g. v1.27.2 it runs without problems. Sorry that i cannot help more at the moment (e.g. git bisect). thanks for your work - bye, Bastian Bittorf _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
