On 4/17/20 3:23 AM, Walter Harms wrote: > hi Daniel, > nice,work. I was just looking at the change an this caught my attention: > > would it be possible just to use *client_config instead of sending the > all the elements individually ? IMHO that would reduce the stress for the > stack > and improve readability. > > if (udhcp_read_interface(client_config.interface, > &client_config.ifindex, > NULL, > - client_config.client_mac) > + client_config.client_mac, > + &client_config.client_hlen, > + &client_config.client_htype) > > btw: In busybox is a lot of talking about size, it would be nice when you > could send a before/after size comparison. >
Thanks for the feedback. I was trying to minimize changes but I agree with your premise re stack stress. I will look into a size comparison. -- Daniel M. Weeks Lead HPC Developer Center for Computational Innovations Rensselaer Polytechnic Institute Troy, NY 12180 518-276-4458 _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
