On 2021/1/4 下午6:01, Kang-Che Sung wrote:
On Sun, Jan 3, 2021 at 12:11 PM Qu Wenruo <[email protected]> wrote:
finit_module() and init_module() system calls have clear specification
to only accept valid ELF image.
Although we try finit_module() on compressed modules to let the kernel
determine if it's an ELF image, but it's not ideal, especially when
newer kernel will complain when some invalid files/memory is passed in.
Treat the kernel better by just doing a very basic ELF header check
before calling finit_module().
Signed-off-by: Qu Wenruo <[email protected]>
What is the reason for not letting the kernel do all the ELF sanity checks?
Performance? Security? For now this looks like extra code to busybox
without obvious benefits.
To avoid possible "Invalid ELF header" error message from kernel.
Since those system calls are only to accept ELF header, kernel has its
right to info the caller that it got some invalid ELF header (even if
it's just compressed file).
Or did you mean, busybox pursues size so much that it doesn't matter to
not follow system call spec?
Thanks,
Qu
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox
