Hello, I'm not sure if you're aware but Debian didn't have this functionality inside ifupdown. They instead handled the bridge interface configuration with if-pre-up/if-post-down shell scripts [1]. I added those to one of my systems to handle bridge configurations from /etc/network/interfaces. This was some time ago so I can't recall all the details but if I remember correctly those scripts used some argument to brctl which was not available in busybox brctl. In my case I ended up using the original brctl util as a quick way to get it running. Anyway, my concern here is that this patch will probably interfere with using the Debian scripts so my question is if busybox brctl should be made more compatible with the original util instead and then by extension the bridge handling scripts too?
Best regards Alexander Vickberg [1]: https://sources.debian.org/src/bridge-utils/1.6-3/debian/ Den lör 16 jan. 2021 kl 14:38 skrev Joachim Wiberg <[email protected]>: > On Tue, Nov 17, 2020 at 11:42, Denys Vlasenko <[email protected]> > wrote: > > On Sat, May 9, 2020 at 4:38 PM Joachim Nilsson <[email protected]> > wrote: > >> The patch hooks on to the manual method callbacks, adding the bridge > >> interface if it's missing and removing it when taking it down. Like > >> the bridge-utils-interfaces extension of ifupdown in Debian does. > > Is it compatible with Debian extension? > > Yes. Limited to exact names, no regexp matching for interface names > at the moment, e.g. `bridge_ports regex (eth|port)*`, this is on my > list of things to add next. > > There are other bridge_* settings[1] as well, but I wanted to test the > waters first with this, which is very useful on its own. > > >> +#include <stdarg.h> > > Unnecessary, libbb.h includes it > > Ah, of course. I can submit a v2 patch if you'd like? > > > Best regards > /Joachim > > [1]: > https://manpages.debian.org/jessie/bridge-utils/bridge-utils-interfaces.5.en.html > > -- > (@- > //\ Joachim Wiberg :: https://troglobit.com :: > https://github.com/troglobit > V_/_ > _______________________________________________ > busybox mailing list > [email protected] > http://lists.busybox.net/mailman/listinfo/busybox >
_______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
