On Tue, Apr 13, 2021 at 11:03 PM Xabier Oneca -- xOneca
<[email protected]> wrote:
> Hi Peter,
>
> > > Sorry if I trampled down your patch, but I had this patch prepared a
> > > while ago and didn't feel like rebasing my other patches. Indeed,
> > > yours gave me +10 bytes, so I decided to send my version too. They are
> > > very similar, tho.
> >
> > This is no problem - seeing as your patch is smaller and more well
> > documented, I don't feel trampled on at all.
> > That was my first time submitting a patch anywhere - I had fun writing
> > it anyway.
>
> Well... Your patch was very nice, and I first doubted if I should send
> my version.
>
> In the end Denys accepted your version... sort of :)
>
> He over-shrunk the code, and now 'touch -am file' does not work. :S
Looks like a kernel-side problem to me: with [OMIT, OMIT],
utimensat does not even check existence of the file!
$ strace ./busybox touch -am NOTEXIST
execve("./busybox", ["./busybox", "touch", "-am", "NOTEXIST"],
0x7fff92092028 /* 54 vars */) = 0
strace: [ Process PID=29202 runs in 32 bit mode. ]
set_thread_area({entry_number:-1, base_addr:0x8143d6c, limit:1048575,
seg_32bit:1, contents:0, read_exec_only:0, limit_in_pages:1,
seg_not_present:0, useable:1}) = 0 (entry_number:12)
set_tid_address(0x81445d0) = 29202
getuid32() = 0
utimensat(AT_FDCWD, "NOTEXIST", [UTIME_OMIT, UTIME_OMIT], 0) = 0
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ !!!!
exit_group(0) = ?
+++ exited with 0 +++
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox
