Hi Aaro,
On 1/24/22 20:21, Aaro Koskinen wrote:
Hi,
On Mon, Jan 24, 2022 at 01:12:25PM -0300, Walter Lozano wrote:
In my specific use case, I try to run some Debian scripts, that make use of
some of those long options, of course not all of them. Since I was already
there I thought it would be nice to add them, since these kind of overhead
can be enabled only if needed.
Yes, I think it's a valid reason to add them if some widely used
scripts/programs use them.
From my understanding long options were enabled if
ENABLE_FEATURE_GREP_CONTEXT, which has some sense, since the color
would be a nice improvement in that case.
Following the idea that users who use ENABLE_FEATURE_GREP_CONTEXT with color
are looking for a full featured grep I thought that no additional
configuration options should we created to handle this.
There is a separate LONG_OPTS feature that users can enable, maybe you
should use that instead.
As mentioned the current implementation uses long options in case
ENABLE_FEATURE_GREP_CONTEXT, so initially I thought in following the
same approach. However, after your comment I understand that this
approach is not the best, and long options should be decoupled.
I'll send a V2.
Regards,
Walter
--
Walter Lozano
Collabora Ltd.
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox
