The URL gets truncated if ENABLE_FEATURE_HTTPD_BASIC_AUTH or
ENABLE_FEATURE_HTTPD_CGI is set, but it is only restored if
ENABLE_FEATURE_HTTPD_BASIC_AUTH is set. This breaks index.html redirects
for configurations that have CGI enabled but basic auth disabled.

Fixes: 91a58b207ea0 ("httpd: no need to strcpy() when we only need to copy one 
byte")
Signed-off-by: Ben Wolsieffer <[email protected]>
---
 networking/httpd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/networking/httpd.c b/networking/httpd.c
index ffc58e10b..67b4ecfe4 100644
--- a/networking/httpd.c
+++ b/networking/httpd.c
@@ -2614,7 +2614,7 @@ static void handle_incoming_and_exit(const 
len_and_sockaddr *fromAddr)
        /* !CGI: it can be only GET or HEAD */
 #endif
 
-#if ENABLE_FEATURE_HTTPD_BASIC_AUTH
+#if ENABLE_FEATURE_HTTPD_BASIC_AUTH || ENABLE_FEATURE_HTTPD_CGI
        /* Restore truncated .../index.html */
        if (urlp[-1] == '/')
                urlp[0] = index_page[0];
-- 
2.37.0

_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to