On 4/26/23 14:30, Michael Tokarev wrote:
What defining _GNU_SOURCE is supposed to do here?
It's a very interesting place to #define it.
It's like doing LFS this way:

Nothing, that's an oversight from my side..
Thanks for pointing it out!

#include <stdio.h>
#define _FILE_OFFSET_BITS 64
// use 64bit off_t here

It just doesn't work. In both cases, those definitions are checked
within the header files to enable/disable certain functionality.
Such #define does absolutely nothing after #includes.
If anything, you can use -D_GNU_SOURCE=1 on the command line.

This is actually what I did in v1, I was later suggested to move it into the 
bb_libtest.c file (see [1] - in this specific case I have no preference on the 
matter) and I was apparently not really awake when I sent the v2.

I'll send a v3 shortly.

[1]: http://lists.busybox.net/pipermail/busybox/2023-April/090287.html
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to