Hi Dominique, On Mon, May 06, 2024 at 03:06:22PM +0900, Dominique Martinet wrote: > Ladislav Michl wrote on Mon, May 06, 2024 at 07:48:53AM +0200: > > Yet another gentle ping. It will be sent approximately once a year until > > some reaction seen. > > Oh, I had just noticed the same thing a bit ago and considered > changing the bb_simple_perror_msg to the _and_die variant, but stopped > as that wouldn't print the date anymore (as date should) > > Either this or die variant would be appreciated, I didn't appreciate > some "set time" script not returning an error while not setting the date > either.
Thanks for review. Above is the exact same reason why this patch was created. > code looks good to me: > Reviewed-by: Dominique Martinet <asmad...@codewreck.org> > > On commit message it might help to add a bloatcheck (remove patch, make > baseline, re-apply patch, make bloatcheck) Ok, for completeness: function old new delta date_main 835 842 +7 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/0 up/down: 7/0) Total: 7 bytes text data bss dec hex filename 652657 10339 1744 664740 a24a4 busybox_old 652664 10339 1744 664747 a24ab busybox_unstripped Lets wait a little for input from maintainers. If required I'll resend as v3. Thanks _______________________________________________ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
