Re: [PATCH] hexdump: add test to verify -n4 -e '"%u"'

[Clayton Craft]

On Wed, 23 Oct 2024 15:11:20 +0200 Natanael Copa <ncopa at alpinelinux.org> 
wrote:
> I git bisected the bug to:
> commit e2287f99fe6f21fd6435ad04340170ad4ba5f6b3

I found that if this one byte is reverted from the patch you blamed, then your 
test passes:

diff --git a/libbb/dump.c b/libbb/dump.c
index b406a2428..92b0d762c 100644
--- a/libbb/dump.c
+++ b/libbb/dump.c
@@ -200,7 +200,7 @@ static NOINLINE void rewrite(priv_dumper_t *dumper, FS *fs)
                                pr->flags = F_INT;
                                if (e > int_convs + 1) /* not d or i? */
                                        pr->flags = F_UINT;
-                               byte_count_str = "\010\004\002\001";
+                               byte_count_str = "\004\002\001";
                                goto DO_BYTE_COUNT;
                        } else
                        if (strchr(int_convs, *p1)) { /* %d etc */


-Clayton
_______________________________________________
busybox mailing list
busybox@busybox.net
https://lists.busybox.net/mailman/listinfo/busybox