Carlos Vara wrote:
Hi all!

Currently I am submitting patches to try to pass more TCK tests, and I'm not
sure if I should enclose unit tests along with the patches.

Basically, if tests are added, they will probably be a replication of the
tests already available in the TCK, and having duplicated code isn't good.
On the other hand, maybe you value having more "own" test coverage and you
don't want or prefer not to rely on the TCK to ensure proper behavior.

Please, let me know what you prefer, as by my side it is no problem at all
to add unit tests.

Regards,
Carlos

As long as additional own tests help to more precisely test the classes, I appreciate them. Today I also added an own test to reproduce a bug found from a TCK test. This creates some duplicate test-code, but currently I think getting the framework stable and well tested is worth more than have the set of tests in a "beautiful" form. When we are done with bug fixing and TCK testing, we could refactor the tests afterwards to eliminate duplicates.

Thanks for your work, Carlos!

Regards,
Roman

Reply via email to