Circular dependency check produces false positives
--------------------------------------------------
Key: BVAL-23
URL: https://issues.apache.org/jira/browse/BVAL-23
Project: BeanValidation
Issue Type: Bug
Components: jsr303
Affects Versions: 0.1-incubating
Reporter: Carlos Vara
Current checks for circular dependencies only use object identity, so for
example, if the same bean is in two places in the same array, it is detected as
a circular dependency even though it is not.
Fix adds the current path to the checks, so circular dependencies are only
detected when the same bean has previously been validated in a subpath of the
current path.
NOTE: Of the 2 validation contexts available, I have only adapted
GroupValidationContextImpl (part of bval-jsr303), I haven't adapted
BeanValidationContext (part of bval-core) as it hasn't access to PathImpl (to
check for subpaths) and as far as I can tell it's not being used in a jsr303
context. Can be easily fixed if my assumption is wrong though.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
