congratulations and welcome then ;) LieGrue, strub
--- On Wed, 5/26/10, Carlos Vara <[email protected]> wrote: > From: Carlos Vara <[email protected]> > Subject: Re: [jira] Updated: (BVAL-63) use java.util.ServiceLoader in > DefaultValidationProviderResolver#getValidationProviders() > To: [email protected] > Date: Wednesday, May 26, 2010, 10:35 AM > Hi Mark, > > I filed an ICLA last week. I'm currently waiting to get my > account created > :-) > > Regards, > Carlos > > On Wed, May 26, 2010 at 12:30, Mark Struberg <[email protected]> > wrote: > > > btw Carlos, > > > > Considering your pretty high activity here and the > fact that you already > > shipped a few patches, would you mind to file an iCLA > [1] ? > > > > There is a short paragraph about what it is about in > [2]. > > > > Usually this is the first step for becoming well > integrated into the Apache > > family :) > > > > txs and LieGrue, > > strub > > > > > > [1] http://www.apache.org/licenses/icla.txt > > [2] http://www.apache.org/licenses/ > > > > --- On Wed, 5/26/10, Carlos Vara (JIRA) <[email protected]> > wrote: > > > > > From: Carlos Vara (JIRA) <[email protected]> > > > Subject: [jira] Updated: (BVAL-63) use > java.util.ServiceLoader in > > > DefaultValidationProviderResolver#getValidationProviders() > > > To: [email protected] > > > Date: Wednesday, May 26, 2010, 9:52 AM > > > > > > [ > > https://issues.apache.org/jira/browse/BVAL-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > > > ] > > > > > > Carlos Vara updated BVAL-63: > > > ---------------------------- > > > > > > Attachment: > bval-jsr303-63.patch > > > > > > Patch for SPI file. License added and TCK tests > pass. > > > > > > > use java.util.ServiceLoader in > > > > DefaultValidationProviderResolver#getValidationProviders() > > > > > > > > > > ----------------------------------------------------------------------------------------- > > > > > > > > > > > Key: BVAL-63 > > > > > > > URL: https://issues.apache.org/jira/browse/BVAL-63 > > > > > > > Project: BeanValidation > > > > Issue > Type: Bug > > > > Affects Versions: > 0.1-incubating > > > > > Reporter: > > > Mark Struberg > > > > > Assignee: > > > Mark Struberg > > > > > > > Fix For: 0.2-incubating > > > > > > > > > Attachments: > > > bval-jsr303-63.patch > > > > > > > > > > > > 4.4.4.1 > > > > > By default, providers are resolved > using the > > > Service Provider pattern described in > > > > > > > http://java.sun.com/j2se/1.5.0/docs/guide/jar/jar.html#Service%20Provider. > > > Bean Validation providers must supply a > > > > > service provider configuration file by > creating a > > > text file javax.validation.spi.ValidationProvider > and > > > placing > > > > > it in the META-INF/services directory > of one of > > > its jar files. The content of the file should > contain the > > > name of the > > > > > provider implementation class of the > > > javax.validation.spi.ValidationProvider > interface. > > > > But we internally currently dont use the > > > java.util.ServiceLoader but do a > > > > cl.getResources(SPI_CFG); > > > > instead in > > > > DefaultValidationProviderResolver#getValidationProviders() > > > > This is imo a bug in our impl! > > > > See here for how to use the ServiceLoader > mechanism > > > properly: > > > > > > https://svn.apache.org/repos/asf/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/plugins/PluginLoader.java > > > > > > > > > -- > > > This message is automatically generated by JIRA. > > > - > > > You can reply to this email to add a comment to > the issue > > > online. > > > > > > > > > > > > > > >
