On Wed, Jun 23, 2010 at 12:54 AM, Donald Woods (JIRA) <[email protected]>wrote:
> > [ > https://issues.apache.org/jira/browse/BVAL-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] > > Donald Woods resolved BVAL-59. > ------------------------------ > > Fix Version/s: 0.2-incubating > Resolution: Fixed > > Committed something slightly different in r956982. > Used the buildnumber-maven-plugin to get the svn revision, but still used > the maven-antrun-plugin to generate a > META-INF/org.apache.bval.revision.properties file, as we have code in > org.apache.bval.util.BeanValidationVersion.java which allows users to > retrieve the version info from the cmdline (or programmatically) - > > $ java -jar bval-core-0.2-incubating-SNAPSHOT.jar > Project: Apache Bean Validation > Version: 0.2-incubating-SNAPSHOT > Revision: 956971 > . . . > > I don't want to loose this feature, as it has been a critical feature over > in OpenJPA (and Geronimo) for us and users to quickly determine what version > is being used when bugs are reported. If there is a way reliably read in > the info from the MANIFEST.MF or POM in both Java SE, OSGi and Java EE > environments, then I'd be willing to remove the antrun code. > I believe that the MANIFEST.MF should be good enough for all three environments. Afterall, the MANIFEST.MF is intended to maintain information related to the build itself (such has the JDK version, who built the code etc.), isn't it? However, in the case of the OSGi bundle, its MANIFEST.MF doesn't aggregate the headers defined in embedded code (including Implementation-Build). Therefore, we need to insert the header into the MANIFEST.MF through the bundle plugin. Thanks, Senaka. > > > > Write or reuse an scm-plugin mojo to capture the svn revision > > ------------------------------------------------------------- > > > > Key: BVAL-59 > > URL: https://issues.apache.org/jira/browse/BVAL-59 > > Project: BeanValidation > > Issue Type: Improvement > > Components: build > > Affects Versions: 0.1-incubating > > Reporter: Donald Woods > > Assignee: Donald Woods > > Priority: Minor > > Fix For: 0.2-incubating > > > > Attachments: patch.out > > > > > > Suggested build improvement from David Jencks - > > I don't think its worth the trouble to use antrun to figure out the svn > version. Maven already creates a property file that includes the project > version. If anyone really wants this info, I'd hope they would write an > scm-plugin mojo to do it. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > -- Senaka Fernando Associate Technical Lead WSO2 Inc. E-mail: senaka AT wso2.com; Mobile: +94 77 322 1818 http://www.wso2.com/ - "Lean . Enterprise . Middleware"
