[ 
https://issues.apache.org/jira/browse/BVAL-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886532#action_12886532
 ] 

Matt Benson edited comment on BVAL-75 at 7/8/10 6:39 PM:
---------------------------------------------------------

Oh, and 'mvn test' from bval/ is successful with these changes.

Also, on the javadoc changes, I have used

/**
 * {...@inheritdoc}
 */

for any interface implementation/overridden methods.  Unfortunately my maven-fu 
is too weak to be able to inherit comments from the RI spec source jar even 
when I use the 'ri' profile, but I would expect some Maven maven to be able to 
accomplish that if deemed desirable.  Where comments existed I have included 
those along with the {...@inheritdoc} comment as (IMHO) appropriate.

      was (Author: mbenson):
    Oh, and 'mvn test' from bval/ is successful with these changes.

Also, on the javadoc changes, I have used

/**
 * {...@inheritdoc}
 */

for any interface implementation/overridden methods.  Unfortunately my maven-fu 
is too weak to be able to inherit comments from the RI spec source jar even 
when I use the 'ri' profile, but I would expect some Maven maven to be able to 
accomplish that if deemed desirable.
  
> javadocs, compiler (generics) warnings, etc.
> --------------------------------------------
>
>                 Key: BVAL-75
>                 URL: https://issues.apache.org/jira/browse/BVAL-75
>             Project: BeanValidation
>          Issue Type: Improvement
>          Components: jsr303
>    Affects Versions: 0.2-incubating
>            Reporter: Matt Benson
>         Attachments: core.patch.txt, jsr303.patch.txt
>
>
> Driven by my desire to understand the structure of bval, I undertook the 
> exercise of completing the javadoc, and cleaning up as many compiler warnings 
> as was practical, in the core and jsr303 modules.
> "etc." includes such things as small (method-scoped) refactorings, occasional 
> expansion of wildcard imports, and TODO comments to note possible 
> improvements for future consideration.  I will attach a separate patch for 
> each of the modules I have worked on.
> (jsr303 component selected; "core" not available)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to