On Jul 15, 2010, at 2:31 PM, Simone Tripodi wrote: > Yes I noticed that's optional, thanks for reminding it, but I didn't > understand which caused the dependency had to be added. Just curious, > can you or someone else explain to me why? > Thanks in advance, have a nice day, > Simo >
Simone, The reason for the dependency having been added was a lack of understanding on my part why the method signature of ApacheFactoryContext#createXMLMetaBeanManager was set as MetaBeanManager. One of my larger submitted patches contained a change that made the return type of this method explicitly XMLMetaBeanManager. The volume of my patch was so large that the error went unnoticed until the guice module stopped building. Sorry for the noise, Matt > http://people.apache.org/~simonetripodi/ > http://www.99soft.org/ > > > > On Thu, Jul 15, 2010 at 5:49 PM, Donald Woods <[email protected]> wrote: >> It is optional and the changes made in r962625 were undone using r962634 >> which also fixed the dependency. >> >> -Donald >> >> >> On 7/15/10 4:44 AM, Simone Tripodi wrote: >>> Hi Donald, >>> I'm sure at 100% I missed something in the discussion list, but the >>> guice module doesn't use the xstream module features at all, can you >>> at least point me the discussion why this module is required? Thanks >>> in advance! :) >>> Simo >>> >>> http://people.apache.org/~simonetripodi/ >>> http://www.99soft.org/ >>> >>> >>> >>> On Fri, Jul 9, 2010 at 8:31 PM, <[email protected]> wrote: >>>> Author: dwoods >>>> Date: Fri Jul 9 18:31:49 2010 >>>> New Revision: 962625 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=962625&view=rev >>>> Log: >>>> BVAL-77 Add bval-xstream depend for bval-guice >>>> >>>> Modified: >>>> incubator/bval/trunk/bval-guice/pom.xml >>>> >>>> Modified: incubator/bval/trunk/bval-guice/pom.xml >>>> URL: >>>> http://svn.apache.org/viewvc/incubator/bval/trunk/bval-guice/pom.xml?rev=962625&r1=962624&r2=962625&view=diff >>>> ============================================================================== >>>> --- incubator/bval/trunk/bval-guice/pom.xml (original) >>>> +++ incubator/bval/trunk/bval-guice/pom.xml Fri Jul 9 18:31:49 2010 >>>> @@ -39,7 +39,15 @@ >>>> <dependencies> >>>> <dependency> >>>> <groupId>org.apache.bval</groupId> >>>> - <artifactId>org.apache.bval.bundle</artifactId> >>>> + <artifactId>bval-core</artifactId> >>>> + </dependency> >>>> + <dependency> >>>> + <groupId>org.apache.bval</groupId> >>>> + <artifactId>bval-jsr303</artifactId> >>>> + </dependency> >>>> + <dependency> >>>> + <groupId>org.apache.bval</groupId> >>>> + <artifactId>bval-xstream</artifactId> >>>> </dependency> >>>> <dependency> >>>> <groupId>com.google.inject</groupId> >>>> >>>> >>>> >>> >>
