On Wed, Apr 02, 2008 at 11:51:41PM +0200, Daniel Schierbeck wrote: > On Wed, 2008-04-02 at 23:36 +0200, Jelmer Vernooij wrote: > > Please rename crypt.py to seahorse.py, looks fine otherwise. > Done.
> > My other comment was going to be about "try ; import ; except > > ImportError" being at the top of the file and setting a boolean > > variable rather than doing "try ; import dbus; create_signatures(); > > except ImportError; pass" directly, but I'm not actually sure what > > PEPs say about that. > If there's a PEP I'll follow that, but in general I like the import > statements to be in the top of the page, and there's no difference > in performance here. You've added an unconditional (and pointless) "import dbus" at the top of revisionview.py that will break if dbus is not available. It seems pointless. bb:tweak Cheers, jelmer -- bzr-gtk mailing list [email protected] Modify settings or unsubscribe at: https://lists.canonical.com/mailman/listinfo/bzr-gtk
