Am Fri, 11 Apr 2008 17:38:55 -0300 schrieb Javier Derderian:
> On Fri, Apr 11, 2008 at 10:33 AM, Jelmer Vernooij
> <[EMAIL PROTECTED]> wrote:
>
>> Hi Javier,
>>
>> Thanks for working on bzr-gtk :-)
>>
>> Am Donnerstag, den 10.04.2008, 16:46 -0300 schrieb Javier Derderian:
>> >
>> > On Thu, Apr 10, 2008 at 2:00 AM, Javier Derderian
>> > <[EMAIL PROTECTED]> wrote:
>> >
>> > On Wed, Apr 9, 2008 at 8:14 PM, Martin Albisetti
>> > <[EMAIL PROTECTED]> wrote:
>> > On Wed, Apr 9, 2008 at 7:53 PM, Javier Derderian
>> > <[EMAIL PROTECTED]>
>> > wrote:
>> > > It needs more work but I want to know if I'm
>> > > headed
>> > in the right direction.
>> >
>> >
>> > The fact you removed indention from many blank lines
>> > makes it really
>> > annoying to read the diff (500 line diff for a 50
>> > line change).
>> >
>> > + for item in history:
>> > + numver = ""
>> > + for ver in item[3]:
>> >
>> > This needs some documentation.
>> > What is item[3]?
>> >
>> > dialog.py needs a new line at the end of the file.
>> >
>> >
>> > bb:resubmit
>> >
>> > Please resubmit with these changes, and I'll give it
>> > a test drive meanwhile :)
>> >
>> >
>> > Hi,
>> >
>> > I'll check what can I do to make Eclipse stop deleting empty
>> > indentation lines, it's doing it by himself. Any idea on how
>> > to disable that?
>> >
>> > Thanks.
>> >
>> >
>> >
>> > Ok, here it is again, now much smaller :)
>> bb:resubmit
>>
>> We already have a dialog for selecting revisions, see revbrowser.py.
>>
>> Cheers,
>>
>> Jelmer
>> --
>> Jelmer Vernooij <[EMAIL PROTECTED]> -
>> http://samba.org/~jelmer/<http://samba.org/%7Ejelmer/> Jabber:
>> [EMAIL PROTECTED]
>>
>>
> Ok, I think now it's ok.
> I found a bug (https://bugs.launchpad.net/bzr-gtk/+bug/215872) while
> working on this and the patch is included here or it wouldn't work.
>
> I hope everything is ok now =)
# revision_id: [EMAIL PROTECTED]
# target_branch: file:///home/javier/python/bzr-gtk/upstream/
# testament_sha1: 0b497fa427db624de21f528d85d9c0698cd60dc2
# timestamp: 2008-04-11 17:36:03 -0300
# base_revision_id: [EMAIL PROTECTED]
# cydpxmb18msies2v
#
# Begin patch
=== modified file 'branchview/linegraph.py'
--- branchview/linegraph.py 2008-03-27 16:27:29 +0000
+++ branchview/linegraph.py 2008-04-11 20:34:06 +0000
@@ -42,6 +42,9 @@
curved, kinked, etc.) and to pick the actual colours for each index.
"""
+ if type(start_revs) != list:
+ start_revs = [start_revs]
+
^^^ Please fix the callers rather than working around it this way.
Other than that, looks fine.
bb:tweak.
Cheers,
Jelmer
--
bzr-gtk mailing list
[email protected]
Modify settings or unsubscribe at:
https://lists.canonical.com/mailman/listinfo/bzr-gtk
