Hi Rodolphe, Am Montag, den 07.07.2008, 23:41 +0200 schrieb Rodolphe Pelloux-Prayer: > The attached patch makes the preferences dialog more GNOMEish and adds > the storage of the modified values.
Thanks, this certainly looks a lot nicer than the previous dialog! We don't generally use glade for new functionality since glade removes some flexibility and are slowly eliminating the last glade files. Any chance you can make these changes without involving glade? Two other issues I noticed while reviewing your patch: * some plugins don't have a description and this breaks your patch (it assumes all descriptions are strings rather than None) * The preferences menu item in "bzr viz" is broken * Plugin versions and authors are no longer shown in the plugins list * The ability to register a new page is now gone bb:resubmit Cheers, Jelmer -- Jelmer Vernooij <[EMAIL PROTECTED]> - http://samba.org/~jelmer/ Jabber: [EMAIL PROTECTED] -- bzr-gtk mailing list [email protected] Modify settings or unsubscribe at: https://lists.canonical.com/mailman/listinfo/bzr-gtk
