* Jasper Groenewegen <[EMAIL PROTECTED]> wrote: > Olive has a mix of glade windows and gtk.Dialog instances ...
Consistency is good. :) > I choose to put all Dialogs in olive/olivedialogs.py. I think > this helps to keep the sourcetree simpler. It looks like it was organized before by function, and you want to organize it by type instead. I'm not familiar enough with the code to say whether this is an improvement. I did notice two issues, though... First, there are a lot of "+" lines where you added new dialogs, but no "-" lines to remove the old dialogs. The old ones should be removed. The other issue is in these lines: > - from remove import OliveRemoveDialog > + from olivedialogs import RemoveDialog > remove = OliveRemoveDialog(self.wt, self.wtpath, Looks like a bug to me. These are just surface-level observations, though. Anyone more familiar with the code care to comment? -- Scott -- bzr-gtk mailing list [email protected] Modify settings or unsubscribe at: https://lists.canonical.com/mailman/listinfo/bzr-gtk
