* Jasper Groenewegen <[EMAIL PROTECTED]> wrote: > You mean like this? :) And now I _will_ go to bed.
This seems fine for the purposes of this patch, but after looking a little closer I see something else which should be fixed... and this is what was bugging me initially. I had a hunch I'd find something like this: In olive/__init__.py, the _load_right() function and refresh_right() function should probably have a bunch of common code merged together. They each have over 100 lines in common, and that's a lot of duplication. Everything in _load_right() from "dirs = []" to "liststore.append([gtk.STOCK_FILE, ... ])" seems redundant. So, about 104 lines in can probably be replaced by a call to self.refresh_right(), after resolving the minor differences between the two. To see the differences, I just saved each function to its own file, removed one level of indentation from load_right(), and viewed both in "meld". Does this look like something you'd be willing to fix? If not, I might try it. -- Scott -- bzr-gtk mailing list [email protected] Modify settings or unsubscribe at: https://lists.canonical.com/mailman/listinfo/bzr-gtk
