Re: [MERGE] Olive: sort bookmarks by title

Thu, 17 Jul 2008 13:06:55 -0700

In this case I disagree. The code is the same, true. But this is because the two methods housing the code are very similar. (_load_right and refresh_right). The only difference is that _load_right creates the ListView for the file list and populates it, and refresh_right only repopulates it. It makes more sense to have a separate bundle that puts the creation of the ListView in a separate function (as I did in my branch) and delete _load_right. 
More helper functions is only a sure way to clutter the code some more. :)

Jasper

Jelmer Vernooij wrote:

Jelmer Vernooij has voted resubmit.
Status is now: Resubmit
Comment:
Seems sensible to add a helper function to do this to avoid code duplication.
For details, see: http://bundlebuggy.aaronbentley.com/request/%3C4875F99D.8050609%40xs4all.nl%3E

Attachment: signature.asc
Description: OpenPGP digital signature

-- 
bzr-gtk mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.canonical.com/mailman/listinfo/bzr-gtk

Reply via email to